From 8d52eeafe0088f965f47423ca400b980cec2bf10 Mon Sep 17 00:00:00 2001
From: barredterra <14891507+barredterra@users.noreply.github.com>
Date: Mon, 23 Sep 2024 14:59:24 +0200
Subject: [PATCH] fix: don't catch S3 upload error prematurely

---
 .../doctype/s3_backup_settings/s3_backup_settings.py     | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/frappe/integrations/doctype/s3_backup_settings/s3_backup_settings.py b/frappe/integrations/doctype/s3_backup_settings/s3_backup_settings.py
index 50f62c57a1..1f807c8204 100755
--- a/frappe/integrations/doctype/s3_backup_settings/s3_backup_settings.py
+++ b/frappe/integrations/doctype/s3_backup_settings/s3_backup_settings.py
@@ -187,10 +187,5 @@ def backup_to_s3():
 
 def upload_file_to_s3(filename, folder, conn, bucket):
 	destpath = os.path.join(folder, os.path.basename(filename))
-	try:
-		print("Uploading file:", filename)
-		conn.upload_file(filename, bucket, destpath)  # Requires PutObject permission
-
-	except Exception:
-		frappe.log_error()
-		notify()
+	print("Uploading file:", filename)
+	conn.upload_file(filename, bucket, destpath)  # Requires PutObject permission