vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(type-check): Allow some slack for bool to be int or float

Browse source
This commit is contained in:
Gavin D'souza 2022-11-29 20:13:39 +05:30
parent f3250808f0
commit 8e125f577e
1 changed files with 7 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
frappe/utils/typing_validations.py
View file

@ -3,24 +3,9 @@ from typing import Callable, ForwardRef, Union
from typeguard import check_type
def qualified_name(obj) -> str:
"""
Return the qualified name (e.g. package.module.Type) for the given object.
Builtins and types from the :mod:`typing` package get special treatment by having the module
name stripped from the generated name.
"""
discovered_type = obj if isclass(obj) else type(obj)
module, qualname = discovered_type.__module__, discovered_type.__qualname__
if module == "typing":
return obj
elif module in {"types", "builtins"}:
return qualname
else:
return f"{module}.{qualname}"
SLACK_DICT = {
bool: (int, bool, float),
}
def validate_argument_types(func: Callable, args: tuple, kwargs: dict):
@ -53,6 +38,10 @@ def validate_argument_types(func: Callable, args: tuple, kwargs: dict):
elif any(isinstance(x, (ForwardRef, str)) for x in getattr(current_arg_type, "__args__", [])):
continue
# allow slack for Frappe types
if current_arg_type in SLACK_DICT:
current_arg_type = SLACK_DICT[current_arg_type]
param_def = func_params.get(current_arg)
# add default value's type in acceptable types