From 8ef7d1f7fb2d7af3448ece171e194f4cdf1d2ccd Mon Sep 17 00:00:00 2001
From: Safwan Samsudeen <safwansamsudeen.c@gmail.com>
Date: Wed, 25 Feb 2026 12:08:01 +0530
Subject: [PATCH] refactor: use common variable for src url

---
 frappe/core/doctype/file/file.js | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/frappe/core/doctype/file/file.js b/frappe/core/doctype/file/file.js
index 6495aa4c1b..9df2829307 100644
--- a/frappe/core/doctype/file/file.js
+++ b/frappe/core/doctype/file/file.js
@@ -48,20 +48,22 @@ frappe.ui.form.on("File", {
 	preview_file: function (frm) {
 		let $preview = "";
 		let file_extension = frm.doc.file_type.toLowerCase();
+		const full_file_url = frm.doc.file_url + "?fid=" + frm.doc.name;
+		const src_url = frappe.utils.escape_html(full_file_url);
 
-		if (frappe.utils.is_image_file(frm.doc.file_url)) {
+		if (frappe.utils.is_image_file(full_file_url)) {
 			$preview = $(`<div class="img_preview">
 				<img
 					class="img-responsive"
 					style="max-width: 500px";
-					src="${frappe.utils.escape_html(frm.doc.file_url + "?fid=" + frm.doc.name)}"
+					src="${src_url}"
 					onerror="${frm.toggle_display("preview", false)}"
 				/>
 			</div>`);
-		} else if (frappe.utils.is_video_file(frm.doc.file_url)) {
+		} else if (frappe.utils.is_video_file(full_file_url)) {
 			$preview = $(`<div class="img_preview">
 				<video width="480" height="320" controls>
-					<source src="${frappe.utils.escape_html(frm.doc.file_url + "?fid=" + frm.doc.name)}">
+					<source src="${src_url}">
 					${__("Your browser does not support the video element.")}
 				</video>
 			</div>`);
@@ -72,16 +74,14 @@ frappe.ui.form.on("File", {
 						style="background:#323639;"
 						width="100%"
 						height="1190"
-						src="${frappe.utils.escape_html(frm.doc.file_url + "?fid=" + frm.doc.name)}" type="application/pdf"
+						src="${src_url}" type="application/pdf"
 					>
 				</object>
 			</div>`);
 		} else if (file_extension === "mp3") {
 			$preview = $(`<div class="img_preview">
 				<audio width="480" height="60" controls>
-					<source src="${frappe.utils.escape_html(
-						frm.doc.file_url + "?fid=" + frm.doc.name
-					)}" type="audio/mpeg">
+					<source src="${src_url}" type="audio/mpeg">
 					${__("Your browser does not support the audio element.")}
 				</audio >
 			</div>`);