From 8f00aae1603c63f58adaf260b094ef887a16c207 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Thu, 29 Feb 2024 16:22:02 +0530 Subject: [PATCH] fix: lock the doc before deleting Locking only prevents this kinda race conditions: - User A deletes doc - User B modifies doc so that it's not deletable anymore. --- frappe/model/delete_doc.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/model/delete_doc.py b/frappe/model/delete_doc.py index 4463188208..47aea6a836 100644 --- a/frappe/model/delete_doc.py +++ b/frappe/model/delete_doc.py @@ -104,7 +104,7 @@ def delete_doc( pass else: - doc = frappe.get_doc(doctype, name) + doc = frappe.get_doc(doctype, name, for_update=True) if not for_reload: update_flags(doc, flags, ignore_permissions)