From 8feba5fa9b084d93158bc23ff14d2f52cfa571d1 Mon Sep 17 00:00:00 2001 From: Aditya Hase Date: Wed, 9 Sep 2020 20:52:45 +0530 Subject: [PATCH] fix(pdf): Cleanup temporary files after pdf generation This was removed in https://github.com/frappe/frappe/pull/7358 --- frappe/utils/pdf.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/frappe/utils/pdf.py b/frappe/utils/pdf.py index 51febb5f72..7699cbc522 100644 --- a/frappe/utils/pdf.py +++ b/frappe/utils/pdf.py @@ -52,6 +52,8 @@ def get_pdf(html, options=None, output=None): output.appendPagesFromReader(reader) else: raise + finally: + cleanup(options) if "password" in options: password = options["password"] @@ -184,10 +186,7 @@ def prepare_header_footer(soup): return options -def cleanup(fname, options): - if os.path.exists(fname): - os.remove(fname) - +def cleanup(options): for key in ("header-html", "footer-html"): if options.get(key) and os.path.exists(options[key]): os.remove(options[key])