From 90bd55690a33207abecc87bb9fec0975f792d176 Mon Sep 17 00:00:00 2001 From: Akhil Narang Date: Wed, 25 Sep 2024 17:57:13 +0530 Subject: [PATCH] refactor(query_report): simplify logic Reduce one level of nesting Signed-off-by: Akhil Narang --- frappe/desk/query_report.py | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/frappe/desk/query_report.py b/frappe/desk/query_report.py index d17caaba1e..0579321a0d 100644 --- a/frappe/desk/query_report.py +++ b/frappe/desk/query_report.py @@ -791,11 +791,10 @@ def validate_filters_permissions(report_name, filters=None, user=None): filters = json.loads(filters) report = frappe.get_doc("Report", report_name) - for fieldname, value in filters.items(): - for field in report.filters: - if field.fieldname == fieldname and field.fieldtype == "Link": - linked_doctype = field.options - if not has_permission(doctype=linked_doctype, doc=value, user=user): - frappe.throw( - _("You do not have permission to access {0}: {1}.").format(linked_doctype, value) - ) + for field in report.filters: + if field.fieldname in filters and field.fieldtype == "Link": + linked_doctype = field.options + if not has_permission(doctype=linked_doctype, doc=filters[field], user=user): + frappe.throw( + _("You do not have permission to access {0}: {1}.").format(linked_doctype, filters[field]) + )