vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Merge pull request #6082 from netchampfaris/int-control-fix

Browse source 
fix(Int control): Skip evaluating numbers with commas
This commit is contained in:
Faris Ansari 2018-09-12 10:57:20 +05:30 • committed by GitHub
commit 9136df623e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
frappe/public/js/frappe/form/controls/int.js
View file

@ -20,7 +20,11 @@ frappe.ui.form.ControlInt = frappe.ui.form.ControlData.extend({
});
},
eval_expression: function(value) {
if (typeof value==='string' && value.match(/^[0-9+-/* ]+$/)) {
if (typeof value==='string'
&& value.match(/^[0-9+-/* ]+$/)
// strings with commas are evaluated incorrectly
// for e.g 47,186.00 -> 186
&& !value.includes(',')) {
try {
return eval(value);
} catch (e) {