From 13a06c110eb2ac30c2670b69b4ab93879a9c6e16 Mon Sep 17 00:00:00 2001 From: rohitwaghchaure Date: Tue, 27 Mar 2018 10:59:51 +0530 Subject: [PATCH 1/2] [Fix] Not able to delete row in modal table (#5262) --- frappe/public/js/frappe/form/grid.js | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/form/grid.js b/frappe/public/js/frappe/form/grid.js index a5a14ac26c..caaa8036cc 100644 --- a/frappe/public/js/frappe/form/grid.js +++ b/frappe/public/js/frappe/form/grid.js @@ -74,6 +74,7 @@ frappe.ui.form.Grid = Class.extend({ }, setup_check: function() { var me = this; + this.wrapper.on('click', '.grid-row-check', function(e) { var $check = $(this); if($check.parents('.grid-heading-row:first').length!==0) { @@ -95,9 +96,13 @@ frappe.ui.form.Grid = Class.extend({ var dirty = false; let tasks = []; + me.deleted_docs = []; me.get_selected().forEach((docname) => { tasks.push(() => { + if (!me.frm) { + me.deleted_docs.push(docname); + } me.grid_rows_by_docname[docname].remove(); dirty = true; }); @@ -338,10 +343,17 @@ frappe.ui.form.Grid = Class.extend({ get_data: function() { var data = this.frm ? this.frm.doc[this.df.fieldname] || [] - : this.df.get_data(); + : this.get_modal_data(); data.sort(function(a, b) { return a.idx - b.idx}); return data; }, + get_modal_data: function() { + return this.df.get_data().filter(data => { + if (!this.deleted_docs || !in_list(this.deleted_docs, data.name)) { + return data; + } + }); + }, set_column_disp: function(fieldname, show) { if($.isArray(fieldname)) { var me = this; From 0eca5db3b45b5791ce5bec7ada7c33a60b12810c Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Tue, 27 Mar 2018 12:05:18 +0600 Subject: [PATCH 2/2] bumped to version 10.1.12 --- frappe/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/__init__.py b/frappe/__init__.py index 0878720fd5..3559c4b9e7 100644 --- a/frappe/__init__.py +++ b/frappe/__init__.py @@ -14,7 +14,7 @@ import os, sys, importlib, inspect, json from .exceptions import * from .utils.jinja import get_jenv, get_template, render_template, get_email_from_template -__version__ = '10.1.11' +__version__ = '10.1.12' __title__ = "Frappe Framework" local = Local()