diff --git a/frappe/core/doctype/communication/communication.py b/frappe/core/doctype/communication/communication.py index 5f4754d5f7..a8a245a8af 100644 --- a/frappe/core/doctype/communication/communication.py +++ b/frappe/core/doctype/communication/communication.py @@ -60,7 +60,6 @@ class Communication(Document): elif self.communication_type in ("Chat", "Notification", "Bot"): if self.reference_name == frappe.session.user: message = self.as_dict() - print message message['broadcast'] = True frappe.publish_realtime('new_message', message, after_commit=True) else: diff --git a/frappe/desk/doctype/todo/todo.py b/frappe/desk/doctype/todo/todo.py index c9b511d757..2d30feaec0 100644 --- a/frappe/desk/doctype/todo/todo.py +++ b/frappe/desk/doctype/todo/todo.py @@ -103,5 +103,4 @@ def new_todo(description): frappe.get_doc({ 'doctype': 'ToDo', 'description': description - }).insert() - frappe.local.flags.commit = True \ No newline at end of file + }).insert() \ No newline at end of file diff --git a/frappe/desk/page/messages/messages.js b/frappe/desk/page/messages/messages.js index 9cdd270d77..6e6299d144 100644 --- a/frappe/desk/page/messages/messages.js +++ b/frappe/desk/page/messages/messages.js @@ -44,22 +44,22 @@ frappe.desk.pages.Messages = Class.extend({ setup_realtime: function() { var me = this; - frappe.realtime.on('new_message', function(comment) { + frappe.realtime.on('new_message', function(comment) { if(comment.modified_by !== user || comment.communication_type === 'Bot') { if(frappe.get_route()[0] === 'messages') { - var current_contact = $(cur_page.page).find('[data-contact]').data('contact'); - var on_broadcast_page = current_contact === user; - if ((current_contact == comment.owner) + var current_contact = $(cur_page.page).find('[data-contact]').data('contact'); + var on_broadcast_page = current_contact === user; + if ((current_contact == comment.owner) || (on_broadcast_page && comment.broadcast) || current_contact === 'Bot' && comment.communication_type === 'Bot') { setTimeout(function() { me.prepend_comment(comment); }, 1000); - } + } } else { - frappe.utils.notify(__("Message from {0}", [comment.sender_full_name]), comment.content); + frappe.utils.notify(__("Message from {0}", [comment.sender_full_name]), comment.content); } } - }); + }); }, prepend_comment: function(comment) { diff --git a/frappe/desk/page/messages/messages_main.html b/frappe/desk/page/messages/messages_main.html index 9e00fe7fea..063afb3756 100644 --- a/frappe/desk/page/messages/messages_main.html +++ b/frappe/desk/page/messages/messages_main.html @@ -8,7 +8,7 @@ class="form-control messages-textarea">
- {{ __("Ctrl + Enter to post") }}