vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Merge pull request #33720 from frappe/mergify/bp/develop/pr-33718

Browse source 
fix: only consider the Frappe and ERPNext apps for setup completion checks (backport #33718)
This commit is contained in:
rohitwaghchaure 2025-08-20 20:29:06 +05:30 • committed by GitHub
commit 939fd9e58f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
frappe/__init__.py
View file

@ -1511,7 +1511,13 @@ def is_setup_complete():
if not frappe.db.table_exists("Installed Application"):
return setup_complete
if all(frappe.get_all("Installed Application", {"has_setup_wizard": 1}, pluck="is_setup_complete")):
if all(
frappe.get_all(
"Installed Application",
{"app_name": ("in", ["frappe", "erpnext"])},
pluck="is_setup_complete",
)
):
setup_complete = True
return setup_complete

14
frappe/core/doctype/installed_applications/installed_applications.py
View file

@ -32,17 +32,11 @@ class InstalledApplications(Document):
self.delete_key("installed_applications")
for app in frappe.utils.get_installed_apps_info():
has_setup_wizard = 0
if app.get("app_name") == "frappe" or frappe.get_hooks(app_name=app.get("app_name")).get(
"setup_wizard_stages"
):
has_setup_wizard = 1
has_setup_wizard = 1
setup_complete = app_wise_setup_details.get(app.get("app_name")) or 0
if app.get("app_name") == "india_compliance":
setup_complete = app_wise_setup_details.get("erpnext") or 0
if app.get("app_name") == "insights":
setup_complete = app_wise_setup_details.get("frappe") or 0
if app.get("app_name") not in ["frappe", "erpnext"]:
setup_complete = 0
has_setup_wizard = 0
self.append(
"installed_applications",