From 93aabafca37d3ec57b9c42c175fd531c0ae1473e Mon Sep 17 00:00:00 2001
From: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
Date: Tue, 2 Dec 2025 23:57:00 +0100
Subject: [PATCH] ci: upload cypress recordings on failure (#35031)

---
 .github/workflows/_base-ui-tests.yml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.github/workflows/_base-ui-tests.yml b/.github/workflows/_base-ui-tests.yml
index d504158cbb..1c6038ab92 100644
--- a/.github/workflows/_base-ui-tests.yml
+++ b/.github/workflows/_base-ui-tests.yml
@@ -103,6 +103,7 @@ jobs:
           echo "BROWSER_PATH=$(which chrome)" >> $GITHUB_ENV
 
       - name: Run Tests
+        id: ui-tests
         run: |
           source ${GITHUB_WORKSPACE}/env/bin/activate
           bench --site test_site \
@@ -129,11 +130,13 @@ jobs:
           name: coverage-js-${{ matrix.index }}
           path: ./apps/${{ github.event.repository.name }}/.cypress-coverage/clover.xml
       - name: Compress Cypress Videos
+        if: steps.ui-tests.outcome == 'failure'
         run: | 
             if find ./cypressVideos -mindepth 1 | read; then
               zip -r cypress_recordings.zip ./cypressVideos
             fi
       - name: Upload Cypress Videos
+        if: steps.ui-tests.outcome == 'failure'
         uses: actions/upload-artifact@v5
         with:
           name: Cypress CI Video Recordings