From cb5a9e887d066a20fc1f54c510b85e2734f1cf13 Mon Sep 17 00:00:00 2001 From: Shivam Mishra Date: Tue, 15 Dec 2020 16:49:08 +0530 Subject: [PATCH 1/2] feat: add patch to update desk page icons --- frappe/patches.txt | 3 ++- .../v13_0/update_icons_in_customized_desk_pages.py | 13 +++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 frappe/patches/v13_0/update_icons_in_customized_desk_pages.py diff --git a/frappe/patches.txt b/frappe/patches.txt index 9e09d6364f..27bde82453 100644 --- a/frappe/patches.txt +++ b/frappe/patches.txt @@ -320,4 +320,5 @@ frappe.patches.v13_0.remove_custom_link execute:frappe.delete_doc("DocType", "Footer Item") frappe.patches.v13_0.replace_field_target_with_open_in_new_tab frappe.core.doctype.role.patches.v13_set_default_desk_properties -frappe.patches.v13_0.add_switch_theme_to_navbar_settings \ No newline at end of file +frappe.patches.v13_0.add_switch_theme_to_navbar_settings +frappe.patches.v13_0.update_icons_in_customized_desk_pages \ No newline at end of file diff --git a/frappe/patches/v13_0/update_icons_in_customized_desk_pages.py b/frappe/patches/v13_0/update_icons_in_customized_desk_pages.py new file mode 100644 index 0000000000..01c16b5e5a --- /dev/null +++ b/frappe/patches/v13_0/update_icons_in_customized_desk_pages.py @@ -0,0 +1,13 @@ +from __future__ import unicode_literals +import frappe + +def execute(): + pages = frappe.get_all("Desk Page", { "is_standard": False }, fields=["name", "extends", "for_user"]) + default_icon = {} + for page in pages: + if page.extends and page.for_user: + if not default_icon.get(page.extends): + default_icon[page.extends] = frappe.db.get_value("Desk Page", page.extends, "icon") + + icon = default_icon.get(page.extends) + frappe.db.set_value("Desk Page", page.name, "icon", icon) \ No newline at end of file From ab3795f48fc1ef4e1d042c7594b00ddaa0d9b542 Mon Sep 17 00:00:00 2001 From: Suraj Shetty Date: Tue, 15 Dec 2020 17:31:19 +0530 Subject: [PATCH 2/2] fix: Update icons patch --- frappe/patches/v13_0/update_icons_in_customized_desk_pages.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frappe/patches/v13_0/update_icons_in_customized_desk_pages.py b/frappe/patches/v13_0/update_icons_in_customized_desk_pages.py index 01c16b5e5a..da7d054682 100644 --- a/frappe/patches/v13_0/update_icons_in_customized_desk_pages.py +++ b/frappe/patches/v13_0/update_icons_in_customized_desk_pages.py @@ -2,12 +2,12 @@ from __future__ import unicode_literals import frappe def execute(): - pages = frappe.get_all("Desk Page", { "is_standard": False }, fields=["name", "extends", "for_user"]) + pages = frappe.get_all("Desk Page", filters={ "is_standard": False }, fields=["name", "extends", "for_user"]) default_icon = {} for page in pages: if page.extends and page.for_user: if not default_icon.get(page.extends): default_icon[page.extends] = frappe.db.get_value("Desk Page", page.extends, "icon") - + icon = default_icon.get(page.extends) frappe.db.set_value("Desk Page", page.name, "icon", icon) \ No newline at end of file