From 9579ab7be92cb44ca9e1c7bfc4e124ee3751c5b0 Mon Sep 17 00:00:00 2001 From: barredterra <14891507+barredterra@users.noreply.github.com> Date: Mon, 24 Apr 2023 16:12:28 +0200 Subject: [PATCH] fix: show edit button only if write permitted --- frappe/desk/doctype/note/note.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/frappe/desk/doctype/note/note.js b/frappe/desk/doctype/note/note.js index fe6e234187..e55a1ec724 100644 --- a/frappe/desk/doctype/note/note.js +++ b/frappe/desk/doctype/note/note.js @@ -4,11 +4,12 @@ frappe.ui.form.on("Note", { frm.is_note_editable = false; frm.events.set_editable(frm, frm.is_note_editable); - // toggle edit - frm.add_custom_button(__("Editing mode"), function () { - frm.is_note_editable = !frm.is_note_editable; - frm.events.set_editable(frm, frm.is_note_editable); - }); + if (frm.has_perm("write")) { + frm.add_custom_button(__("Editing mode"), function () { + frm.is_note_editable = !frm.is_note_editable; + frm.events.set_editable(frm, frm.is_note_editable); + }); + } } }, set_editable: function (frm, editable) {