From 95ebeca4abe05100181dda4e11338ecbd992bd2d Mon Sep 17 00:00:00 2001 From: Rushabh Mehta Date: Fri, 18 Dec 2020 11:40:50 +0530 Subject: [PATCH] fix(router): open in a new tab --- frappe/public/js/frappe/router.js | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/frappe/public/js/frappe/router.js b/frappe/public/js/frappe/router.js index d9fe08c161..848f131fd9 100644 --- a/frappe/public/js/frappe/router.js +++ b/frappe/public/js/frappe/router.js @@ -39,14 +39,15 @@ $('body').on('click', 'a', function(e) { return false; }; + const href = e.currentTarget.getAttribute('href'); + // click handled, but not by href - if (e.currentTarget.getAttribute('onclick')) { + if (e.currentTarget.getAttribute('onclick') // has a handler + || (e.ctrlKey || e.metaKey) // open in a new tab + || href==='#') { // hash is home return; } - const href = e.currentTarget.getAttribute('href'); - if (href==='#') return; - if (href==='') { return override('/app'); }