vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

perf: lazy load dashboard links (#21752)

Browse source
This commit is contained in:
Ankush Menat 2023-07-21 13:10:30 +05:30 • committed by GitHub
parent ebacca3863
commit 9608c32db7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 26 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
frappe/public/js/frappe/form/dashboard.js
View file

@ -48,7 +48,7 @@ frappe.ui.form.Dashboard = class FormDashboard {
body_html: this.stats_area_row,
});
this.transactions_area = $(`<div class="transactions"></div`);
this.transactions_area = $(`<div class="transactions"></div>`);
this.links_area = this.make_section({
label: __("Connections"),
@ -205,6 +205,8 @@ frappe.ui.form.Dashboard = class FormDashboard {
show = true;
}
this._fetched_counts = false;
if (this.data.heatmap) {
this.render_heatmap();
show = true;
@ -227,7 +229,21 @@ frappe.ui.form.Dashboard = class FormDashboard {
$(el).removeClass("hidden");
}
});
!this.frm.is_new() && this.set_open_count();
this.observe_link_render();
}
observe_link_render() {
let me = this;
let element = this.links_area.wrapper[0];
new IntersectionObserver((entries, observer) => {
entries.forEach((entry) => {
if (entry.intersectionRatio > 0) {
me.set_open_count();
observer.disconnect(); // only required for first load.
}
});
}).observe(element);
}
init_data() {
@ -387,7 +403,13 @@ frappe.ui.form.Dashboard = class FormDashboard {
}
set_open_count() {
if (!this.data || !this.data.transactions || !this.data.fieldname) {
if (
!this.data ||
!this.data.transactions ||
!this.data.fieldname ||
this.frm.is_new() ||
this._fetched_counts
) {
return;
}
@ -443,6 +465,7 @@ frappe.ui.form.Dashboard = class FormDashboard {
});
me.frm.dashboard_data = r.message;
me._fetched_counts = true;
me.frm.trigger("dashboard_update");
},
});