From 96d9f2624b9d8523420e66cf19e11e369958cbfc Mon Sep 17 00:00:00 2001 From: Aditya Hase Date: Mon, 24 Feb 2020 13:47:34 +0530 Subject: [PATCH] fix(monitor): Maintain MAX_LOG entries in cache --- frappe/monitor.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/frappe/monitor.py b/frappe/monitor.py index 3efb92e91c..b0e7f023dd 100644 --- a/frappe/monitor.py +++ b/frappe/monitor.py @@ -81,11 +81,10 @@ class Monitor: def store(json_data): - if frappe.cache().llen(MONITOR_REDIS_KEY) >= 1000000: - frappe.cache().ltrim(MONITOR_REDIS_KEY, len(logs) - 1, -1) - frappe.cache().rpush(MONITOR_REDIS_KEY, json_data) - else: - frappe.cache().rpush(MONITOR_REDIS_KEY, json_data) + MAX_LOGS = 1000000 + if frappe.cache().llen(MONITOR_REDIS_KEY) > MAX_LOGS: + frappe.cache().ltrim(MONITOR_REDIS_KEY, 1, -1) + frappe.cache().rpush(MONITOR_REDIS_KEY, json_data) def flush():