From f7aa85d4ae30a091dc84078d46d9c1ce0664c1e4 Mon Sep 17 00:00:00 2001 From: Ejaaz Khan Date: Thu, 16 Oct 2025 08:52:10 +0530 Subject: [PATCH] fix: grid height overflow on y-axis --- frappe/public/js/frappe/list/base_list.js | 5 ++--- frappe/public/js/frappe/list/list_view.js | 8 +++----- frappe/public/scss/desk/list.scss | 3 ++- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/frappe/public/js/frappe/list/base_list.js b/frappe/public/js/frappe/list/base_list.js index cef1ae3077..1990ab8b4e 100644 --- a/frappe/public/js/frappe/list/base_list.js +++ b/frappe/public/js/frappe/list/base_list.js @@ -451,10 +451,9 @@ frappe.views.BaseList = class BaseList { set_result_height() { this.$result[0].style.removeProperty("height"); // place it at the footer of the page + let result_element_dom = this.$result[0].getBoundingClientRect(); const resultContainerHeight = - window.innerHeight - - this.$result.get(0).offsetTop - - this.$paging_area.get(0).offsetHeight; + window.innerHeight - this.$paging_area.get(0).offsetHeight - result_element_dom.top; this.$result.parent(".result-container").css({ height: resultContainerHeight + "px", }); diff --git a/frappe/public/js/frappe/list/list_view.js b/frappe/public/js/frappe/list/list_view.js index d2968e9bef..123f8fb8e1 100644 --- a/frappe/public/js/frappe/list/list_view.js +++ b/frappe/public/js/frappe/list/list_view.js @@ -804,11 +804,9 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList { } if (frappe.is_mobile() && col.type == "Field" && [3, 4].includes(i)) { - left_html += `
${this.get_column_html( - col, - doc, - true - )}
`; + left_html += `
${this.get_column_html(col, doc, true)}
`; } else { left_html += this.get_column_html(col, doc, false); } diff --git a/frappe/public/scss/desk/list.scss b/frappe/public/scss/desk/list.scss index e0dfc19a12..3fb27bfe9f 100644 --- a/frappe/public/scss/desk/list.scss +++ b/frappe/public/scss/desk/list.scss @@ -649,7 +649,8 @@ input.list-header-checkbox { padding-left: 37px; } } - .mobile-layout:not(.mobile-layout ~ .mobile-layout) { + .mobile-layout-seperator:not(.mobile-layout-seperator + ~ .mobile-layout-seperator) { padding-left: 27px; margin-right: 6px;