fix(UX): show perm server messages on file uploader (#21331)
This commit is contained in:
parent
32f54b6734
commit
98260b3c88
2 changed files with 15 additions and 1 deletions
|
|
@ -97,6 +97,7 @@ def has_permission(
|
|||
if not perm:
|
||||
push_perm_check_log(
|
||||
_("User {0} does not have access to this document").format(frappe.bold(user))
|
||||
+ f": {_(doc.doctype)} - {doc.name}"
|
||||
)
|
||||
else:
|
||||
if ptype == "submit" and not cint(meta.is_submittable):
|
||||
|
|
|
|||
|
|
@ -473,7 +473,20 @@ function upload_file(file, i) {
|
|||
} else if (xhr.status === 403) {
|
||||
file.failed = true;
|
||||
let response = JSON.parse(xhr.responseText);
|
||||
file.error_message = `Not permitted. ${response._error_message || ''}`;
|
||||
file.error_message = `Not permitted. ${response._error_message || ''}.`;
|
||||
|
||||
try {
|
||||
// Append server messages which are useful hint for perm issues
|
||||
let server_messages = JSON.parse(response._server_messages);
|
||||
|
||||
server_messages.forEach((m) => {
|
||||
m = JSON.parse(m);
|
||||
file.error_message += `\n ${m.message} `
|
||||
})
|
||||
} catch (e) {
|
||||
console.warning("Failed to parse server message", e)
|
||||
}
|
||||
|
||||
|
||||
} else if (xhr.status === 413) {
|
||||
file.failed = true;
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue