From 9839c4d5d644786a6bc2df3f9c93fecd04db1821 Mon Sep 17 00:00:00 2001 From: Gavin D'souza Date: Wed, 20 Apr 2022 11:58:35 +0530 Subject: [PATCH] test: Use new_doc instead of get_doc --- frappe/core/doctype/file/test_file.py | 5 ++--- frappe/model/create_new.py | 2 -- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/frappe/core/doctype/file/test_file.py b/frappe/core/doctype/file/test_file.py index a7792cf00f..e34d6c9318 100644 --- a/frappe/core/doctype/file/test_file.py +++ b/frappe/core/doctype/file/test_file.py @@ -396,9 +396,8 @@ class TestFile(FrappeTestCase): self.assertRaises(OSError, file1.save) def test_file_url_validation(self): - test_file: File = frappe.get_doc( - {"doctype": "File", "file_name": "logo", "file_url": "https://frappe.io/files/frappe.png"} - ) + test_file: File = frappe.new_doc("File") + test_file.update({"file_name": "logo", "file_url": "https://frappe.io/files/frappe.png"}) self.assertIsNone(test_file.validate()) diff --git a/frappe/model/create_new.py b/frappe/model/create_new.py index 8671008f82..51810c3e18 100644 --- a/frappe/model/create_new.py +++ b/frappe/model/create_new.py @@ -23,8 +23,6 @@ def get_new_doc(doctype, parent_doc=None, parentfield=None, as_dict=False): doc = copy.deepcopy(frappe.local.new_doc_templates[doctype]) - # doc = make_new_doc(doctype) - set_dynamic_default_values(doc, parent_doc, parentfield) if as_dict: