vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

perf: cache parsed assets_json instead of string

Browse source
This commit is contained in:
Sagar Vora 2022-03-31 12:28:23 +05:30
parent 0c8b16b204
commit 987b47557d
1 changed files with 11 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
frappe/utils/__init__.py
View file

@ -793,38 +793,24 @@ def get_build_version():
def get_assets_json():
if not hasattr(frappe.local, "assets_json"):
cache = frappe.cache()
assets = None
# using .get instead of .get_value to avoid pickle.loads
try:
if not frappe.conf.developer_mode:
assets_json = cache.get("assets_json").decode('utf-8')
else:
assets_json = None
except (UnicodeDecodeError, AttributeError, ConnectionError):
assets_json = None
if not frappe.conf.developer_mode:
assets = cache.get_value("assets_json", shared=True)
if not assets_json:
if not assets:
# get merged assets.json and assets-rtl.json
assets_dict = frappe.parse_json(
frappe.read_file("assets/assets.json")
)
assets = frappe.parse_json(frappe.read_file("assets/assets.json"))
if assets_rtl := frappe.read_file("assets/assets-rtl.json"):
assets.update(frappe.parse_json(assets_rtl))
assets_rtl = frappe.read_file("assets/assets-rtl.json")
if assets_rtl:
assets_dict.update(
frappe.parse_json(assets_rtl)
)
frappe.local.assets_json = frappe.as_json(assets_dict)
# save in cache
cache.set_value("assets_json", frappe.local.assets_json,
shared=True)
cache.set_value("assets_json", assets, shared=True)
return assets_dict
else:
# from cache, decode and send
frappe.local.assets_json = frappe.safe_decode(assets_json)
frappe.local.assets_json = assets
return frappe.parse_json(frappe.local.assets_json)
return frappe.local.assets_json
def get_bench_relative_path(file_path):