vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

chore: remove else condition, improve formatting & comment in insert_doc

Browse source
This commit is contained in:
phot0n 2022-05-06 22:56:07 +05:30
parent 534911a1b4
commit 98c60dbb1f
1 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
frappe/client.py
View file

@ -2,7 +2,7 @@
# License: MIT. See LICENSE
import json
import os
from typing import TYPE_CHECKING, Dict, List
from typing import TYPE_CHECKING
import frappe
import frappe.model
@ -482,20 +482,21 @@ def validate_link(doctype: str, docname: str, fields=None):
return values
def insert_doc(doc: Dict) -> "Document":
"""Inserts document and returns parent document with appended child document
if `doc` is child document else just returns the inserted document"""
def insert_doc(doc) -> "Document":
"""Inserts document and returns parent document object with appended child document
if `doc` is child document else returns the inserted document object
:param doc: doc to insert (dict)"""
doc = frappe._dict(doc)
if frappe.is_table(doc.doctype):
if not (doc.parenttype and doc.parent and doc.parentfield):
frappe.throw(_("parenttype, parent and parentfield are required to insert a child record"))
frappe.throw(_("Parenttype, Parent and Parentfield are required to insert a child record"))
# inserting a child record
parent = frappe.get_doc(doc.parenttype, doc.parent)
parent.append(doc.parentfield, doc)
parent.save()
return parent
else:
doc = frappe.get_doc(doc).insert()
return doc
return frappe.get_doc(doc).insert()