From dee08b38a206c402454636be57c55729af1501fc Mon Sep 17 00:00:00 2001 From: makeen Date: Tue, 19 Nov 2019 23:25:20 +0100 Subject: [PATCH] feat: use "title_field" in delete confirmation message use "title_field" if autoname is "hash" in delete confirmation message Example: for translations, when delete one, it asks "Permanently delete f1f99806c0?" now it asks: "Permanently delete text_to_translate (f1f99806c0)?" --- frappe/public/js/frappe/model/model.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/model/model.js b/frappe/public/js/frappe/model/model.js index 0c6388c681..48d0d14037 100644 --- a/frappe/public/js/frappe/model/model.js +++ b/frappe/public/js/frappe/model/model.js @@ -525,7 +525,13 @@ $.extend(frappe.model, { }, delete_doc: function(doctype, docname, callback) { - frappe.confirm(__("Permanently delete {0}?", [docname]), function() { + var title = docname; + var title_field = frappe.get_meta(doctype).title_field; + if (frappe.get_meta(doctype).autoname == "hash" && title_field) { + var title = frappe.model.get_value(doctype, docname, title_field); + title += " (" + docname + ")"; + } + frappe.confirm(__("Permanently delete {0}?", [title]), function() { return frappe.call({ method: 'frappe.client.delete', args: {