From d15a6d6da0d32bd14db910d59c56d8e117d32000 Mon Sep 17 00:00:00 2001
From: Suraj Shetty <surajshetty3416@gmail.com>
Date: Thu, 26 Feb 2026 11:20:50 +0530
Subject: [PATCH] fix: Only show "Edit Values" button if template has something
 to edit

Closes: https://github.com/frappe/frappe/issues/18612
---
 .../website_settings/website_settings.js      | 29 +++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/frappe/website/doctype/website_settings/website_settings.js b/frappe/website/doctype/website_settings/website_settings.js
index 07051588bd..a09101b062 100644
--- a/frappe/website/doctype/website_settings/website_settings.js
+++ b/frappe/website/doctype/website_settings/website_settings.js
@@ -16,6 +16,10 @@ frappe.ui.form.on("Website Settings", {
 		frm.add_custom_button(__("View Website"), () => {
 			window.open("/", "_blank");
 		});
+
+		// Check if templates have fields and show/hide edit button
+		frm.events.check_template_has_fields(frm, "navbar_template");
+		frm.events.check_template_has_fields(frm, "footer_template");
 	},
 
 	set_banner_from_image: function (frm) {
@@ -100,11 +104,36 @@ frappe.ui.form.on("Website Settings", {
 			frappe.show_alert(__("Please select {0}", [frm.get_docfield(template_field).label]));
 			return;
 		}
+
 		let values = JSON.parse(frm.doc[values_field] || "{}");
 		open_web_template_values_editor(template, values).then((new_values) => {
 			frm.set_value(values_field, JSON.stringify(new_values));
 		});
 	},
+
+	check_template_has_fields(frm, template_field) {
+		let template = frm.doc[template_field];
+		let button_field = "edit_" + template_field + "_values";
+
+		if (!template || template === "Standard Navbar" || template === "Standard Footer") {
+			frm.toggle_display(button_field, false);
+			return;
+		}
+
+		frappe.model.with_doc("Web Template", template, () => {
+			let doc = frappe.model.get_doc("Web Template", template);
+			let has_fields = doc.fields && doc.fields.length > 0;
+			frm.toggle_display(button_field, has_fields);
+		});
+	},
+
+	navbar_template(frm) {
+		frm.events.check_template_has_fields(frm, "navbar_template");
+	},
+
+	footer_template(frm) {
+		frm.events.check_template_has_fields(frm, "footer_template");
+	},
 });
 
 frappe.ui.form.on("Top Bar Item", {