vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(prepared-report): Show data from report matching filters and owner

Browse source 
This fixes permission issues since users can only see the
report that they themselves have generated.

Also report filters and data won't mismatch.
This commit is contained in:
Aditya Hase 2018-12-01 00:29:40 +05:30
parent d76a0136dd
commit 9ced1a2886
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
frappe/desk/query_report.py
View file

@ -169,7 +169,7 @@ def run(report_name, filters=None, user=None):
dn = filters.get("prepared_report_name")
else:
dn = ""
result = get_prepared_report_result(report, filters, dn)
result = get_prepared_report_result(report, filters, dn, user)
else:
result = generate_report_result(report, filters, user)
@ -178,9 +178,10 @@ def run(report_name, filters=None, user=None):
return result
def get_prepared_report_result(report, filters, dn=""):
def get_prepared_report_result(report, filters, dn="", user=None):
latest_report_data = {}
doc_list = frappe.get_all("Prepared Report", filters={"status": "Completed", "report_name": report.name})
# Only look for completed prepared reports with given filters.
doc_list = frappe.get_all("Prepared Report", filters={"status": "Completed", "report_name": report.name, "filters": json.dumps(filters), "owner": user})
doc = None
if len(doc_list):
if dn: