vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

perf: get all file data at once when downloading private file

Browse source
This commit is contained in:
Sagar Vora 2023-04-27 16:11:24 +05:30
parent 7042dca5dd
commit 9cf7f2b311
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
frappe/utils/response.py
View file

@ -224,16 +224,16 @@ def download_private_file(path: str) -> Response:
"""Checks permissions and sends back private file"""
can_access = False
files = frappe.get_all("File", filters={"file_url": path}, pluck="name")
files = frappe.get_all("File", filters={"file_url": path}, fields="*")
# this file might be attached to multiple documents
# if the file is accessible from any one of those documents
# then it should be downloadable
for fname in files:
file: "File" = frappe.get_doc("File", fname)
if can_access := file.is_downloadable():
for file_data in files:
file: "File" = frappe.get_doc(doctype="File", **file_data)
if file.is_downloadable():
break
if not can_access:
else:
raise Forbidden(_("You don't have permission to access this file"))
make_access_log(doctype="File", document=file.name, file_type=os.path.splitext(path)[-1][1:])