From 9d63208c9cdd79b6ccf95af2bc96b6dd8e4e98ed Mon Sep 17 00:00:00 2001
From: David Arnold <dgx.arnold@gmail.com>
Date: Sat, 12 Oct 2024 22:31:40 +0200
Subject: [PATCH] fix: test record generation (#28102)

* chore: improve log record of testing command invokation

* chore(testing): narrower specificacion of the persistence log

* fix(testing): append raw record source data to globalTestRecords
---
 frappe/commands/testing.py       | 19 ++++++++++++++++++-
 frappe/tests/utils/generators.py | 14 ++++++++++++--
 2 files changed, 30 insertions(+), 3 deletions(-)

diff --git a/frappe/commands/testing.py b/frappe/commands/testing.py
index 20c5ab2a48..2502546821 100644
--- a/frappe/commands/testing.py
+++ b/frappe/commands/testing.py
@@ -61,7 +61,24 @@ def main(
 
 	# Prepare debug log message
 	debug_params = []
-	for param_name in ["site", "app", "module", "doctype", "module_def", "doctype_list_path"]:
+	for param_name in [
+		"site",
+		"app",
+		"module",
+		"doctype",
+		"module_def",
+		"verbose",
+		"tests",
+		"force",
+		"profile",
+		"junit_xml_output",
+		"doctype_list_path",
+		"failfast",
+		"case",
+		"skip_before_tests",
+		"pdb_on_exceptions",
+		"selected_categories",
+	]:
 		param_value = locals()[param_name]
 		if param_value is not None:
 			debug_params.append(f"{param_name}={param_value}")
diff --git a/frappe/tests/utils/generators.py b/frappe/tests/utils/generators.py
index 985ca654a4..cf8085e35b 100644
--- a/frappe/tests/utils/generators.py
+++ b/frappe/tests/utils/generators.py
@@ -214,10 +214,20 @@ def _sync_records(
 			if "doctype" not in record:
 				record["doctype"] = _sub_doctype
 			_rec = _try_create(record)
+			# no_nulls: some buidness logic might check absence of an attribute, closer to the raw records
+			# no_default_fields: we want to keep especially name, doctype
 			# convert_dates_to_str: same as when loaded from log file above
-			_rec = _rec.as_dict(convert_dates_to_str=True)
+			# no_child_table_fields: we don't neer prent{,field,type} et al fields
+			# no_private_properties: these are internal to the document lifecycle and not a property of data records
+			_rec = _rec.as_dict(
+				no_nulls=True,
+				no_default_fields=False,
+				convert_dates_to_str=True,
+				no_child_table_fields=True,
+				no_private_properties=True,
+			)
 			created.append(_rec)
-			frappe.local.test_objects[_sub_doctype].append(MappingProxyType(_rec))
+			frappe.local.test_objects[_sub_doctype].append(MappingProxyType(record))
 
 		_logstr = f"{_sub_doctype} ({len(created)})"