From 0646be24ded9d83e106006307475d514cbfea8ee Mon Sep 17 00:00:00 2001 From: ljain112 Date: Thu, 22 Aug 2024 18:32:15 +0530 Subject: [PATCH] fix: update idx and name in table before rendering result rows --- frappe/public/js/frappe/form/grid.js | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/frappe/public/js/frappe/form/grid.js b/frappe/public/js/frappe/form/grid.js index b69847bb5e..3c1bd4bee1 100644 --- a/frappe/public/js/frappe/form/grid.js +++ b/frappe/public/js/frappe/form/grid.js @@ -123,6 +123,7 @@ export default class Grid { this.setup_add_row(); this.setup_grid_pagination(); + this.update_idx_and_name(); this.custom_buttons = {}; this.grid_buttons = this.wrapper.find(".grid-buttons"); @@ -145,6 +146,17 @@ export default class Grid { } } + update_idx_and_name() { + this.data.forEach((d, ri) => { + if (d.idx === undefined) { + d.idx = ri + 1; + } + if (d.name === undefined) { + d.name = "row " + d.idx; + } + }); + } + set_doc_url() { let unsupported_fieldtypes = frappe.model.no_value_type.filter( (x) => frappe.model.table_fields.indexOf(x) === -1 @@ -466,12 +478,6 @@ export default class Grid { if (!d) { return; } - if (d.idx === undefined) { - d.idx = ri + 1; - } - if (d.name === undefined) { - d.name = "row " + d.idx; - } let grid_row; if (this.grid_rows[ri] && !append_row) { grid_row = this.grid_rows[ri];