From 9dcc97cb2611e4cbef6535d68cb648a72a19e4ea Mon Sep 17 00:00:00 2001 From: Shubh Doshi Date: Thu, 19 Feb 2026 10:04:40 +0530 Subject: [PATCH] refactor: updated is_doc_status_readonly condition --- frappe/public/js/workflow_builder/components/Properties.vue | 3 +-- frappe/workflow/doctype/workflow/workflow.py | 2 -- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/frappe/public/js/workflow_builder/components/Properties.vue b/frappe/public/js/workflow_builder/components/Properties.vue index 51ca48f317..b55b3cf51e 100644 --- a/frappe/public/js/workflow_builder/components/Properties.vue +++ b/frappe/public/js/workflow_builder/components/Properties.vue @@ -5,7 +5,7 @@ import { useStore } from "../store"; let store = useStore(); const is_doc_status_readonly = computed(() => { - if (!store.workflow.selected || !("state" in store.workflow.selected.data)) return false; + if (!store.workflow.selected || !(store.workflow.selected.type === "state")) return false; return !store.is_submittable(); }); @@ -37,7 +37,6 @@ let properties = computed(() => { const submittable = store.is_submittable(); - // Auto-reset doc_status to "Draft" for non-submittable doctypes if (!submittable && store.workflow.selected.data.doc_status !== "Draft") { store.workflow.selected.data.doc_status = "Draft"; } diff --git a/frappe/workflow/doctype/workflow/workflow.py b/frappe/workflow/doctype/workflow/workflow.py index c5c6320f00..1ee0cc09ec 100644 --- a/frappe/workflow/doctype/workflow/workflow.py +++ b/frappe/workflow/doctype/workflow/workflow.py @@ -90,11 +90,9 @@ class Workflow(Document): frappe.throw(frappe._("{0} not a valid State").format(state)) - # Check if doctype is submittable meta = frappe.get_meta(self.document_type) is_submittable = meta.is_submittable - # Validate that non-submittable doctypes only have doc_status 0 if not is_submittable: for state in self.states: if cint(state.doc_status or 0) != 0: