From 9df69d214cd6efa3f7100c6db8fe15b4d915baf4 Mon Sep 17 00:00:00 2001 From: "Chinmay D. Pai" Date: Fri, 10 Apr 2020 15:42:58 +0530 Subject: [PATCH] fix: set welcome_email to None if template not found fixes UnboundLocalError: welcome_email referenced before assignment Signed-off-by: Chinmay D. Pai --- frappe/email/doctype/email_group/email_group.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/frappe/email/doctype/email_group/email_group.py b/frappe/email/doctype/email_group/email_group.py index 23495b2d70..b19a134713 100755 --- a/frappe/email/doctype/email_group/email_group.py +++ b/frappe/email/doctype/email_group/email_group.py @@ -68,8 +68,7 @@ def add_subscribers(name, email_list): email_list = email_list.replace(",", "\n").split("\n") template = frappe.db.get_value('Email Group', name, 'welcome_email_template') - if template: - welcome_email = frappe.get_doc("Email Template", template) + welcome_email = frappe.get_doc("Email Template", template) if template else None count = 0 for email in email_list: @@ -108,4 +107,4 @@ def send_welcome_email(welcome_email, email, email_group): ) message = frappe.render_template(welcome_email.response, args) - frappe.sendmail(email, subject=welcome_email.subject, message=message) \ No newline at end of file + frappe.sendmail(email, subject=welcome_email.subject, message=message)