From 9f7c385b112c26a36860deb7c457e627baafb700 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Thu, 28 Mar 2024 15:24:29 +0530 Subject: [PATCH] fix: erase logs in case of complete failure --- frappe/core/doctype/data_import/importer.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/frappe/core/doctype/data_import/importer.py b/frappe/core/doctype/data_import/importer.py index afc9b9487a..a177d85c66 100644 --- a/frappe/core/doctype/data_import/importer.py +++ b/frappe/core/doctype/data_import/importer.py @@ -102,9 +102,13 @@ class Importer: log_index = 0 # Do not remove rows in case of retry after an error or pending data import - if self.data_import.status == "Partial Success" and len(import_log) >= self.data_import.payload_count: + if ( + self.data_import.status in ("Partial Success", "Error") + and len(import_log) >= self.data_import.payload_count + ): # remove previous failures from import log only in case of retry after partial success import_log = [log for log in import_log if log.get("success")] + frappe.db.delete("Data Import Log", {"success": 0, "data_import": self.data_import.name}) # get successfully imported rows imported_rows = []