vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

refactor: remove unnecessary sql_keywords validation in _validate_alias

Browse source 
pypika wraps aliases in backticks, so SQL keywords are safe to use as aliases
This commit is contained in:
Sagar Vora 2025-12-02 00:40:23 +05:30
parent 3dcd80326b
commit a14b11749b
1 changed files with 1 additions and 66 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

67
frappe/database/query.py
View file

@ -2073,78 +2073,13 @@ class SQLFunctionParser:
frappe.throw(_("Empty alias is not allowed"), frappe.ValidationError)
# Alias should be a simple identifier
# Note: pypika wraps aliases in backticks, so anything without backticks is safe
if not IDENTIFIER_PATTERN.match(alias):
frappe.throw(
_("Invalid alias format: {0}. Alias must be a simple identifier.").format(alias),
frappe.ValidationError,
)
# Check for SQL keywords that shouldn't be used as aliases
sql_keywords = {
"select",
"from",
"where",
"join",
"inner",
"left",
"right",
"outer",
"union",
"group",
"order",
"by",
"having",
"limit",
"offset",
"insert",
"update",
"delete",
"create",
"drop",
"alter",
"table",
"index",
"view",
"database",
"schema",
"grant",
"revoke",
"commit",
"rollback",
"transaction",
"begin",
"end",
"if",
"else",
"case",
"when",
"then",
"null",
"not",
"and",
"or",
"in",
"exists",
"between",
"like",
"is",
"as",
"on",
"using",
"distinct",
"all",
"any",
"some",
"true",
"false",
}
if alias.lower() in sql_keywords:
frappe.throw(
_("Alias cannot be a SQL keyword: {0}").format(alias),
frappe.ValidationError,
)
def _validate_function_field_arg(self, field_name: str):
"""Validate a field name used as a function argument."""
if not isinstance(field_name, str):