From a3bb293deffb0b77afb5ce4be4e4d0a395a4e1b2 Mon Sep 17 00:00:00 2001 From: prssanna Date: Tue, 2 Jun 2020 11:05:15 +0530 Subject: [PATCH] fix: check if filters exist and is list --- .../v13_0/update_date_filters_in_user_settings.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/frappe/patches/v13_0/update_date_filters_in_user_settings.py b/frappe/patches/v13_0/update_date_filters_in_user_settings.py index 2d6c123064..d4c6aa1d03 100644 --- a/frappe/patches/v13_0/update_date_filters_in_user_settings.py +++ b/frappe/patches/v13_0/update_date_filters_in_user_settings.py @@ -40,11 +40,12 @@ def update_user_setting_filters(data, key, user_setting): update = False if isinstance(data.get(key), dict): filters = data.get(key).get('filters') - for f in filters: - if f[2] == 'Next' or f[2] == 'Previous': - update = True - f[3] = period_map[f[2]] + ' ' + timespan_map[f[3]] - f[2] = 'Timespan' + if filters and isinstance(filters, list): + for f in filters: + if f[2] == 'Next' or f[2] == 'Previous': + update = True + f[3] = period_map[f[2]] + ' ' + timespan_map[f[3]] + f[2] = 'Timespan' if update: data[key]['filters'] = filters