From a3db75e161c094c52e189124ab4639dbd5055da3 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Mon, 23 Oct 2023 14:14:30 +0530 Subject: [PATCH] fix: use frm.set_value for updating fields (#22860) Just updating frm.doc object doesn't update the underlying model. In Frappe `frm.doc` is NOT the primary representation or source of truth for better or worse. --- frappe/public/js/form_builder/store.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/public/js/form_builder/store.js b/frappe/public/js/form_builder/store.js index 56c5437dc4..6dad866786 100644 --- a/frappe/public/js/form_builder/store.js +++ b/frappe/public/js/form_builder/store.js @@ -201,7 +201,7 @@ export const useStore = defineStore("form-builder-store", () => { let fields = get_updated_fields(); let has_error = validate_fields(fields, doc.value.istable); if (has_error) return has_error; - doc.value.fields = fields; + frm.value.set_value("fields", fields); return fields; } catch (e) { console.error(e);