From a4db4550e9974cfd00c669917aaaee13544d048b Mon Sep 17 00:00:00 2001 From: Marica Date: Fri, 25 Nov 2022 20:55:16 +0530 Subject: [PATCH] fix: Avoid `update_order` twice on Kanban load (#19011) * fix: Avoid `update_order` twice on kanban load - The older logic called `kanban.update()` on a refresh (not on load) and returned from `render()` - Due to a recent PR, it calls `kanban.update()` AND builds a new board on load, which invokes `update_order` twice consecutively and causes a timestamp error to be thrown * chore: Remove redundant condition Co-authored-by: Ritwik Puri --- frappe/public/js/frappe/views/kanban/kanban_view.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/frappe/public/js/frappe/views/kanban/kanban_view.js b/frappe/public/js/frappe/views/kanban/kanban_view.js index 7eccd7ebf8..17339258ab 100644 --- a/frappe/public/js/frappe/views/kanban/kanban_view.js +++ b/frappe/public/js/frappe/views/kanban/kanban_view.js @@ -175,9 +175,7 @@ frappe.views.KanbanView = class KanbanView extends frappe.views.ListView { cur_list: this, user_settings: this.view_user_settings, }); - } - - if (this.kanban && board_name === this.kanban.board_name) { + } else if (board_name === this.kanban.board_name) { this.kanban.update(this.data); } }