From a5b102dcd26dcec987835ea96c5708fc80324142 Mon Sep 17 00:00:00 2001 From: "Indrajith.vs" <91895505+Gubbu77@users.noreply.github.com> Date: Wed, 22 Nov 2023 16:00:09 +0530 Subject: [PATCH] fix: button "Add Chart to Dashboard" visible before saving (#23256) * fix: dashboard chart - add chart to dashboard btn fix * style: format [skip ci] --------- Co-authored-by: Ankush Menat --- .../dashboard_chart/dashboard_chart.js | 26 ++++++++++--------- 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/frappe/desk/doctype/dashboard_chart/dashboard_chart.js b/frappe/desk/doctype/dashboard_chart/dashboard_chart.js index 5d16a6d6d1..3577e9c5ec 100644 --- a/frappe/desk/doctype/dashboard_chart/dashboard_chart.js +++ b/frappe/desk/doctype/dashboard_chart/dashboard_chart.js @@ -30,19 +30,21 @@ frappe.ui.form.on("Dashboard Chart", { frm.disable_form(); } - frm.add_custom_button("Add Chart to Dashboard", () => { - const dialog = frappe.dashboard_utils.get_add_to_dashboard_dialog( - frm.doc.name, - "Dashboard Chart", - "frappe.desk.doctype.dashboard_chart.dashboard_chart.add_chart_to_dashboard" - ); + if (!frm.is_new()) { + frm.add_custom_button("Add Chart to Dashboard", () => { + const dialog = frappe.dashboard_utils.get_add_to_dashboard_dialog( + frm.doc.name, + "Dashboard Chart", + "frappe.desk.doctype.dashboard_chart.dashboard_chart.add_chart_to_dashboard" + ); - if (!frm.doc.chart_name) { - frappe.msgprint(__("Please create chart first")); - } else { - dialog.show(); - } - }); + if (!frm.doc.chart_name) { + frappe.msgprint(__("Please create chart first")); + } else { + dialog.show(); + } + }); + } frm.set_df_property("filters_section", "hidden", 1); frm.set_df_property("dynamic_filters_section", "hidden", 1);