From 89f6861964272bb778c37daa5007620ff776ef82 Mon Sep 17 00:00:00 2001 From: Anand Doshi Date: Fri, 12 Apr 2013 15:44:03 +0530 Subject: [PATCH 1/3] [file manager] [fix] syntax error in save_file --- webnotes/utils/file_manager.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webnotes/utils/file_manager.py b/webnotes/utils/file_manager.py index fe0bb46a5c..44657ba378 100644 --- a/webnotes/utils/file_manager.py +++ b/webnotes/utils/file_manager.py @@ -98,7 +98,7 @@ def save_file(fname, content, dt, dn): os.remove(temp_fname) else: # get_new_version name - fname = get_new_fname_based_on_version(file_path, fname) + fname = get_new_fname_based_on_version(files_path, fname) # rename os.rename(temp_fname, os.path.join(files_path, fname)) From da2c4b9050415bd4b25bf607c51f92b7732b135b Mon Sep 17 00:00:00 2001 From: Anand Doshi Date: Fri, 12 Apr 2013 16:15:44 +0530 Subject: [PATCH 2/3] [datatype] [fix] use var in for loop of keys and values functions --- public/js/legacy/utils/datatype.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/public/js/legacy/utils/datatype.js b/public/js/legacy/utils/datatype.js index c5beba7842..1494aaa04e 100644 --- a/public/js/legacy/utils/datatype.js +++ b/public/js/legacy/utils/datatype.js @@ -148,12 +148,12 @@ function replace_all(s, t1, t2) { function keys(obj) { var mykeys=[]; - for (key in obj) mykeys[mykeys.length]=key; + for (var key in obj) mykeys[mykeys.length]=key; return mykeys; } function values(obj) { var myvalues=[]; - for (key in obj) myvalues[myvalues.length]=obj[key]; + for (var key in obj) myvalues[myvalues.length]=obj[key]; return myvalues; } From 62e8b16c00e810aabca1fc8435002786782e4586 Mon Sep 17 00:00:00 2001 From: Anand Doshi Date: Fri, 12 Apr 2013 22:02:49 +0530 Subject: [PATCH 3/3] [attachments] [fix] cur_frm.get_files --- public/js/legacy/widgets/form/clientscriptAPI.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/public/js/legacy/widgets/form/clientscriptAPI.js b/public/js/legacy/widgets/form/clientscriptAPI.js index 5584ff71a2..539f8ff973 100644 --- a/public/js/legacy/widgets/form/clientscriptAPI.js +++ b/public/js/legacy/widgets/form/clientscriptAPI.js @@ -219,7 +219,7 @@ _f.Frm.prototype.call_server = function(method, args, callback) { } _f.Frm.prototype.get_files = function() { - return cur_frm.attachments.get_file_list().keys().sort(); + return keys(cur_frm.attachments.get_file_list()).sort(); } _f.Frm.prototype.set_query = function(fieldname, opt1, opt2) {