From a7017c43efbca9f9c3bcf508c799f8d3526575bc Mon Sep 17 00:00:00 2001 From: Gavin D'souza Date: Tue, 30 Jun 2020 12:15:51 +0530 Subject: [PATCH] fix: maintain order of doctypes to be removed --- frappe/installer.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/frappe/installer.py b/frappe/installer.py index 8e02e80ae6..d544280228 100755 --- a/frappe/installer.py +++ b/frappe/installer.py @@ -148,7 +148,8 @@ def remove_app(app_name, dry_run=False, yes=False, no_backup=False): linked_doctypes = frappe.get_all("DocField", filters={"fieldtype": "Link", "options": "Module Def"}, fields=['parent']) - doctypes_with_linked_modules = ["Desk Page", "Reports", "Pages", "Web Forms"] + [doctype.parent for doctype in linked_doctypes] + ordered_doctypes = ["Desk Page", "Reports", "Pages", "Web Forms"] + doctypes_with_linked_modules = ordered_doctypes + [doctype.parent for doctype in linked_doctypes if doctype.parent not in ordered_doctypes] # remove desk page, reports, pages, web forms and chart sources for doctype in doctypes_with_linked_modules: