vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(rename): check for permissions for merged document as well

Browse source 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
This commit is contained in:
Akhil Narang 2024-11-27 16:12:13 +05:30
parent 0dcc6280e8
commit a70973b0c5
No known key found for this signature in database
GPG key ID: 9DCC61E211BF645F
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
frappe/model/rename_doc.py
View file

@ -386,10 +386,15 @@ def validate_rename(
kwargs = {"doctype": doctype, "ptype": "write", "print_logs": False}
if old_doc:
kwargs |= {"doc": old_doc}
kwargs["doc"] = old_doc
if not (ignore_permissions or frappe.permissions.has_permission(**kwargs)):
frappe.throw(_("You need write permission to rename"))
frappe.throw(_("You need write permission on {0} {1} to rename").format(doctype, old))
if merge:
kwargs["doc"] = frappe.get_doc(doctype, new)
if not (ignore_permissions or frappe.permissions.has_permission(**kwargs)):
frappe.throw(_("You need write permission on {0} {1} to merge").format(doctype, new))
if not force and not ignore_permissions and not meta.allow_rename:
frappe.throw(_("{0} not allowed to be renamed").format(_(doctype)))