From a709f66889232628645af4520c7c17ec3dfd40be Mon Sep 17 00:00:00 2001
From: prssanna <prssud@gmail.com>
Date: Thu, 25 Feb 2021 13:58:24 +0530
Subject: [PATCH] fix: placeholder for form control fields

---
 frappe/public/js/frappe/form/controls/select.js | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/frappe/public/js/frappe/form/controls/select.js b/frappe/public/js/frappe/form/controls/select.js
index 857063d4a7..ee3119aa37 100644
--- a/frappe/public/js/frappe/form/controls/select.js
+++ b/frappe/public/js/frappe/form/controls/select.js
@@ -25,11 +25,15 @@ frappe.ui.form.ControlSelect = frappe.ui.form.ControlData.extend({
 		}
 	},
 	set_placeholder: function(is_xs_input) {
-		this.$wrapper.append(`
-			<div class="placeholder ellipsis text-extra-muted ${is_xs_input ? 'xs' : ''}">
+		const placeholder_html =
+			`<div class="placeholder ellipsis text-extra-muted ${is_xs_input ? 'xs' : ''}">
 				<span>${this.df.placeholder}</span>
-			</div>`
-		);
+			</div>`;
+		if (this.only_input) {
+			this.$wrapper.append(placeholder_html);
+		} else {
+			this.$wrapper.find('.control-input').append(placeholder_html);
+		}
 		this.toggle_placeholder();
 		this.$input && this.$input.on('select-change', () => this.toggle_placeholder());
 	},