vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: Evaluate assets in sequence (#26208)

Browse source 
Fetching can be done in parallel and out of order but execution should
depend on order specified in args otherwise it breaks things like
calander which has 2 JS file and 2nd one depends on first one.
This commit is contained in:
Ankush Menat 2024-04-29 18:56:20 +05:30 • committed by GitHub
parent e4ed1b98e4
commit a7b7af8311
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
frappe/public/js/frappe/assets.js
View file

@ -91,6 +91,7 @@ class AssetManager {
const version_string =
frappe.boot.developer_mode || window.dev_server ? Date.now() : window._version_number;
let fetched_assets = {};
async function fetch_item(path) {
// Add the version to the URL to bust the cache for non-bundled assets
let url = new URL(path, window.location.origin);
@ -99,13 +100,16 @@ class AssetManager {
url.searchParams.append("v", version_string);
}
const response = await fetch(url.toString());
const body = await response.text();
me.eval_assets(path, body);
fetched_assets[path] = await response.text();
}
frappe.dom.freeze();
const fetch_promises = items.map(fetch_item);
Promise.all(fetch_promises).then(() => {
items.forEach((path) => {
let body = fetched_assets[path];
me.eval_assets(path, body);
});
frappe.dom.unfreeze();
callback?.();
});