From d2becc7f1d604a9e2fce7ebf099ccc9cf6cdd420 Mon Sep 17 00:00:00 2001 From: Sagar Vora Date: Sat, 22 Jul 2023 17:54:41 +0530 Subject: [PATCH] fix: no API call required to set cookie in browser --- frappe/translate.py | 5 ----- frappe/website/js/website.js | 11 +++-------- 2 files changed, 3 insertions(+), 13 deletions(-) diff --git a/frappe/translate.py b/frappe/translate.py index 806ec8e66f..29291fbc02 100644 --- a/frappe/translate.py +++ b/frappe/translate.py @@ -1320,11 +1320,6 @@ def get_all_languages(with_language_name: bool = False) -> list: return frappe.cache.get_value("languages", get_language_codes) -@frappe.whitelist(allow_guest=True) -def set_preferred_language_cookie(preferred_language: str): - frappe.local.cookie_manager.set_cookie("preferred_language", preferred_language) - - def get_preferred_language_cookie(): return frappe.request.cookies.get("preferred_language") diff --git a/frappe/website/js/website.js b/frappe/website/js/website.js index 1430cd22e2..eb576ac4ec 100644 --- a/frappe/website/js/website.js +++ b/frappe/website/js/website.js @@ -394,14 +394,9 @@ $.extend(frappe, { language_switcher.val(language); document.documentElement.lang = language; language_switcher.change(() => { - let lang = language_switcher.val(); - frappe - .call("frappe.translate.set_preferred_language_cookie", { - preferred_language: lang, - }) - .then(() => { - window.location.reload(); - }); + const lang = language_switcher.val(); + document.cookie = `preferred_language=${lang}`; + window.location.reload(); }); }); }