From a893341f95e9dbf9f7e0814fbf2e5f08299a06d2 Mon Sep 17 00:00:00 2001 From: marination Date: Mon, 2 Sep 2024 17:12:23 +0200 Subject: [PATCH] fix: `get_valid_fields` excludes `show_on_timeline`, breaking migrations Co-authored-by: Gavin --- frappe/model/meta.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/model/meta.py b/frappe/model/meta.py index 01f3c91cc8..6c6a66d4a7 100644 --- a/frappe/model/meta.py +++ b/frappe/model/meta.py @@ -232,7 +232,7 @@ class Meta(Document): def get_valid_fields(self) -> list[str]: if not hasattr(self, "_valid_fields"): - if frappe.flags.in_install and self.name in self.special_doctypes: + if (frappe.flags.in_install or frappe.flags.in_migrate) and self.name in self.special_doctypes: self._valid_fields = get_table_columns(self.name) else: self._valid_fields = self.default_fields + [