vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

fix: Update base timeline

Browse source 
- prepare_timeline can have async calls
This commit is contained in:
Suraj Shetty 2020-12-07 18:07:45 +05:30
parent b3a5c317f2
commit a9cc0304ee
1 changed files with 20 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
frappe/public/js/frappe/form/footer/base_timeline.js
View file

@ -40,22 +40,36 @@ class BaseTimeline {
this.timeline_items_wrapper.empty();
this.timeline_items = [];
this.doc_info = this.frm && this.frm.get_docinfo() || {};
this.prepare_timeline_contents();
this.timeline_items.sort((item1, item2) => new Date(item1.creation) - new Date(item2.creation));
this.timeline_items.forEach(this.add_timeline_item.bind(this));
let response = this.prepare_timeline_contents();
if (response instanceof Promise) {
response.then(() => {
this.timeline_items.sort((item1, item2) => new Date(item1.creation) - new Date(item2.creation));
this.timeline_items.forEach(this.add_timeline_item.bind(this));
});
} else {
this.timeline_items.sort((item1, item2) => new Date(item1.creation) - new Date(item2.creation));
this.timeline_items.forEach(this.add_timeline_item.bind(this));
}
}
prepare_timeline_contents() {
//
}
add_timeline_item(item) {
add_timeline_item(item, append_at_the_end=false) {
let timeline_item = this.get_timeline_item(item);
this.timeline_items_wrapper.prepend(timeline_item);
if (append_at_the_end) {
this.timeline_items_wrapper.append(timeline_item);
} else {
this.timeline_items_wrapper.prepend(timeline_item);
}
return timeline_item;
}
add_timeline_items(items, append_at_the_end=false) {
items.forEach((item) => this.add_timeline_item(item, append_at_the_end));
}
get_timeline_item(item) {
// item can have content*, creation*,
// timeline_badge, icon, icon_size,