From aa9f0d365c8e8f6e9f8a8e3d1b416adbf11a2ddd Mon Sep 17 00:00:00 2001 From: Corentin Flr <10946971+cogk@users.noreply.github.com> Date: Wed, 5 Jun 2024 17:22:48 +0200 Subject: [PATCH] fix(File): Unquote file_url only once --- frappe/core/doctype/file/file.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/frappe/core/doctype/file/file.py b/frappe/core/doctype/file/file.py index 13435d5d47..c5b218f42f 100755 --- a/frappe/core/doctype/file/file.py +++ b/frappe/core/doctype/file/file.py @@ -90,6 +90,9 @@ class File(Document): self.name = frappe.generate_hash(length=10) def before_insert(self): + # Ensure correct formatting and type + self.file_url = unquote(self.file_url) if self.file_url else "" + self.set_folder_name() self.set_is_private() self.set_file_name() @@ -117,9 +120,6 @@ class File(Document): if self.is_folder: return - # Ensure correct formatting and type - self.file_url = unquote(self.file_url) if self.file_url else "" - self.validate_attachment_references() # when dict is passed to get_doc for creation of new_doc, is_new returns None