From aba7f29aa68f2b349fbeeb39b7b393d8f3964678 Mon Sep 17 00:00:00 2001 From: Ejaaz Khan Date: Tue, 10 Jun 2025 19:54:13 +0530 Subject: [PATCH] refactor: remove debugging statement --- frappe/core/doctype/docfield/docfield.py | 14 -------------- frappe/model/__init__.py | 2 -- frappe/model/db_query.py | 1 - frappe/model/meta.py | 15 --------------- frappe/public/js/frappe/form/form.js | 4 +--- frappe/public/js/frappe/list/base_list.js | 2 -- frappe/public/js/frappe/list/list_view.js | 3 --- 7 files changed, 1 insertion(+), 40 deletions(-) diff --git a/frappe/core/doctype/docfield/docfield.py b/frappe/core/doctype/docfield/docfield.py index 00f0a80b00..3f6d642e55 100644 --- a/frappe/core/doctype/docfield/docfield.py +++ b/frappe/core/doctype/docfield/docfield.py @@ -159,17 +159,3 @@ class DocField(Document): parent = f" parent={self.parent}" if getattr(self, "parent", None) else "" return f"<{self.fieldtype}{doctype}: {self.fieldname}{docstatus}{parent}{unsaved}>" - - -# TODO: remove this function when all usages are removed -def get_masked_fields(doctype): - return frappe.db.get_values( - doctype="DocField", - filters={ - "parent": doctype, - "parentfield": "fields", - "mask": 1, - }, - fieldname="fieldname", - as_dict=True, - ) diff --git a/frappe/model/__init__.py b/frappe/model/__init__.py index f6eedf5801..994624608c 100644 --- a/frappe/model/__init__.py +++ b/frappe/model/__init__.py @@ -241,8 +241,6 @@ def get_permitted_fields( with_virtual_fields=not ignore_virtual, ) - # print(doctype, " : In permitted fields, \n valid columns: ", permitted_fields, "\n\n\n") - if permission_type == "select": return permitted_fields diff --git a/frappe/model/db_query.py b/frappe/model/db_query.py index 27563323fa..3fc3de7e83 100644 --- a/frappe/model/db_query.py +++ b/frappe/model/db_query.py @@ -694,7 +694,6 @@ from {tables} if "." in column: table, column = column.split(".", 1) - # print(i, "field", column, "permitted_fields") doctype = self.linked_table_aliases[table] if table in self.linked_table_aliases else table doctype = doctype.replace("`", "").removeprefix("tab") diff --git a/frappe/model/meta.py b/frappe/model/meta.py index c182a74e22..b137db862d 100644 --- a/frappe/model/meta.py +++ b/frappe/model/meta.py @@ -227,22 +227,7 @@ class Meta(Document): return self._dynamic_link_fields def get_masked_fields(self): - # print(self.fields, "Indise the meta yes \n\n\n") - # return [df for df in self.fields if df.get("mask")] - # print("inside mask fields: ", self.get("fields", {"mask": 1}), "\n\n\n") - # return self.get("fields", {"mask": 1}) return self.get("fields", {"mask_readonly": 1}) - # fields = self.get("fields", {"mask_readonly": 1}) - # change fieldtype to Data for masked fields - # print("fields: ", fields, "\n\n\n") - # for df in fields: - # print("df: ", df, "\n\n\n") - # if df.get("fieldtype") != "Data": - # df.old_fieldtype = df.fieldtype - # df.fieldtype = "Data" - # return fields - - # return [df for df in self.get("fields", {"mask": 1}) if df.get("fieldtype") != "Data"] @cached_property def _dynamic_link_fields(self): diff --git a/frappe/public/js/frappe/form/form.js b/frappe/public/js/frappe/form/form.js index 673f01cd81..b9c3794d24 100644 --- a/frappe/public/js/frappe/form/form.js +++ b/frappe/public/js/frappe/form/form.js @@ -1178,12 +1178,10 @@ frappe.ui.form.Form = class FrappeForm { mark_mask_fields_readonly() { this.fields.forEach((field) => { if (field.df.mask && field.df.mask_readonly) { - console.log(field.df); - // this.set_df_property(field.df.fieldname, "disabled", "1"); + this.set_df_property(field.df.fieldname, "disabled", "1"); this.set_df_property(field.df.fieldname, "fieldtype", "Date"); } }); - // this.refresh(); } handle_save_fail(btn, on_error) { diff --git a/frappe/public/js/frappe/list/base_list.js b/frappe/public/js/frappe/list/base_list.js index b58bfef3b4..f1b54301ad 100644 --- a/frappe/public/js/frappe/list/base_list.js +++ b/frappe/public/js/frappe/list/base_list.js @@ -526,8 +526,6 @@ frappe.views.BaseList = class BaseList { this.freeze(true); // fetch data from server return frappe.call(args).then((r) => { - // console.log(r, "list view response"); - // render this.prepare_data(r); this.toggle_result_area(); diff --git a/frappe/public/js/frappe/list/list_view.js b/frappe/public/js/frappe/list/list_view.js index 7ba60a23a9..96214e182c 100644 --- a/frappe/public/js/frappe/list/list_view.js +++ b/frappe/public/js/frappe/list/list_view.js @@ -395,9 +395,6 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList { } const fields_in_list_view = this.get_fields_in_list_view(); - - // console.log(fields_in_list_view, "fields_in_list_view"); - // Add rest from in_list_view docfields this.columns = this.columns.concat( fields_in_list_view