From aca5bdb89fbbc80543f3d11070ca4d7b5765723d Mon Sep 17 00:00:00 2001 From: Shivam Mishra Date: Mon, 6 Apr 2020 15:19:32 +0530 Subject: [PATCH] feat: don't rebuild count cache on every insert --- frappe/cache_manager.py | 11 +---------- frappe/hooks.py | 3 +-- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/frappe/cache_manager.py b/frappe/cache_manager.py index 9959ba97bb..50c4c396a2 100644 --- a/frappe/cache_manager.py +++ b/frappe/cache_manager.py @@ -121,7 +121,7 @@ def clear_doctype_map(doctype, name): cache_key = frappe.scrub(doctype) + '_map' frappe.cache().hdel(cache_key, name) -def build_table_count_cache(doc=None, method=None, *args, **kwargs): +def build_table_count_cache(): if (frappe.flags.in_patch or frappe.flags.in_install or frappe.flags.in_migrate @@ -129,15 +129,6 @@ def build_table_count_cache(doc=None, method=None, *args, **kwargs): or frappe.flags.in_setup_wizard): return - if doc and isinstance(doc, Document): - doctype = doc.doctype - - if doc.meta.istable: - return - - if doctype in count_cache_blacklist: - return - _cache = frappe.cache() data = frappe.db.multisql({ "mariadb": """ diff --git a/frappe/hooks.py b/frappe/hooks.py index 1b12b26c3a..03b2a2a62e 100644 --- a/frappe/hooks.py +++ b/frappe/hooks.py @@ -143,8 +143,7 @@ doc_events = { ], "on_change": [ "frappe.social.doctype.energy_point_rule.energy_point_rule.process_energy_points" - ], - "after_insert": "frappe.cache_manager.build_table_count_cache" + ] }, "Event": { "after_insert": "frappe.integrations.doctype.google_calendar.google_calendar.insert_event_in_google_calendar",