From 0334ae32b675438d04f55fb2444f876db2ce3138 Mon Sep 17 00:00:00 2001 From: barredterra <14891507+barredterra@users.noreply.github.com> Date: Fri, 23 Feb 2024 17:09:46 +0100 Subject: [PATCH] fix: add context for row number label Note: I had to remove the `else` branch because `txt` is (and has always been) undefined there. --- frappe/public/js/frappe/form/grid_row.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/frappe/public/js/frappe/form/grid_row.js b/frappe/public/js/frappe/form/grid_row.js index 030dba80a5..f2323e4f67 100644 --- a/frappe/public/js/frappe/form/grid_row.js +++ b/frappe/public/js/frappe/form/grid_row.js @@ -247,8 +247,9 @@ export default class GridRow { // index (1, 2, 3 etc) if (!this.row_index && !this.show_search) { - // REDESIGN-TODO: Make translation contextual, this No is Number - var txt = this.doc ? this.doc.idx : __("No."); + const txt = this.doc + ? this.doc.idx + : __("No.", null, "Title of the 'row number' column"); this.row_check = $( `
@@ -303,8 +304,6 @@ export default class GridRow { }, 500) ); frappe.utils.only_allow_num_decimal(this.row_index.find("input")); - } else { - this.row_index.find("span").html(txt); } this.setup_columns();