From adadb26732c106bd37a4e0915babf09e46ef27cd Mon Sep 17 00:00:00 2001 From: "Chinmay D. Pai" Date: Tue, 30 Jun 2020 17:55:25 +0530 Subject: [PATCH] chore: only validate s3 settings if enabled Signed-off-by: Chinmay D. Pai --- .../doctype/s3_backup_settings/s3_backup_settings.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/frappe/integrations/doctype/s3_backup_settings/s3_backup_settings.py b/frappe/integrations/doctype/s3_backup_settings/s3_backup_settings.py index 6cfd3646b2..c8b007ba7b 100755 --- a/frappe/integrations/doctype/s3_backup_settings/s3_backup_settings.py +++ b/frappe/integrations/doctype/s3_backup_settings/s3_backup_settings.py @@ -19,6 +19,9 @@ from botocore.exceptions import ClientError class S3BackupSettings(Document): def validate(self): + if not self.enabled: + return + if not self.endpoint_url: self.endpoint_url = 'https://s3.amazonaws.com' conn = boto3.client(