From adc745a72c5b005b515de1259440eb55c330a3f2 Mon Sep 17 00:00:00 2001 From: Gavin D'souza Date: Mon, 31 Jan 2022 11:43:24 +0530 Subject: [PATCH] fix: Avoid TypeError when guess_extension returns None --- frappe/core/doctype/file/file.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/frappe/core/doctype/file/file.py b/frappe/core/doctype/file/file.py index 89295fb52f..ee2c9987b6 100755 --- a/frappe/core/doctype/file/file.py +++ b/frappe/core/doctype/file/file.py @@ -660,7 +660,9 @@ def get_extension(filename, extn, content: bytes = None, response: "Response" = content_type = response.headers.get("Content-Type") if content_type: - return mimetypes.guess_extension(content_type)[1:] + _extn = mimetypes.guess_extension(content_type) + if _extn: + return _extn[1:] if extn: # remove '?' char and parameters from extn if present