From f96fe1d8ea51d651aea0693fe8aa34696ed3c95a Mon Sep 17 00:00:00 2001
From: Gavin D'souza <gavin18d@gmail.com>
Date: Mon, 13 Apr 2020 12:24:24 +0530
Subject: [PATCH] feat: dont save document if not updated

This checks if form is dirty and only then allows form saving
---
 frappe/public/js/frappe/form/form.js | 2 +-
 frappe/public/js/frappe/form/save.js | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/frappe/public/js/frappe/form/form.js b/frappe/public/js/frappe/form/form.js
index b55c822ba6..e714418375 100644
--- a/frappe/public/js/frappe/form/form.js
+++ b/frappe/public/js/frappe/form/form.js
@@ -1052,7 +1052,7 @@ frappe.ui.form.Form = class FrappeForm {
 	}
 
 	is_dirty() {
-		return this.doc.__unsaved;
+		return !!this.doc.__unsaved;
 	}
 
 	is_new() {
diff --git a/frappe/public/js/frappe/form/save.js b/frappe/public/js/frappe/form/save.js
index fbc35634f4..d40b3ed341 100644
--- a/frappe/public/js/frappe/form/save.js
+++ b/frappe/public/js/frappe/form/save.js
@@ -21,7 +21,7 @@ frappe.ui.form.save = function (frm, action, callback, btn) {
 		remove_empty_rows();
 
 		$(frm.wrapper).addClass('validated-form');
-		if (check_mandatory()) {
+		if (frm.is_dirty() && check_mandatory()) {
 			_call({
 				method: "frappe.desk.form.save.savedocs",
 				args: { doc: frm.doc, action: action },
@@ -36,6 +36,7 @@ frappe.ui.form.save = function (frm, action, callback, btn) {
 				freeze_message: freeze_message
 			});
 		} else {
+			frappe.show_alert({message: __("Document not updated"), indicator: "yellow"});
 			$(btn).prop("disabled", false);
 		}
 	};